-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(mobile): uploading files in chunk #2101
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
Have you had a chance to test it with your Cloudflare tunnel setup? Can you also test with a local IP on your server? |
I tested this with my CloudFlare tunnel setup with a ~200 MB video and it uploaded without problems. This video consistently fails to upload with the Play Store build of the app. I am unable to test with my local IP, the app says: |
This doesn't actually do chunked uploading like the linked issue describes, right? This only kind of abuses the HTTP/1.1 specification to bypass the length check of Cloudflare, as tested by the PR author. Are regular reverse proxies still able to correctly process such requests? And shouldn't at least a comment be included that states why this header is present at all for future reference? And could this break with HTTP/2 requests? |
@michelheusschen Good info. I did a test with Caddy with default |
Did that Caddy instance still have HTTP/1.1 enabled though? It will negotiate a protocol. |
@bo0tzz I will fall back to HTTP/1.1 caddyserver/caddy#4707 (comment) |
It's true that this is not real "chunking". It just omits the content length so that CloudFlare doesn't respond with HTTP 413. Once a request is already underway, it's more complicated to track the amount of data transfered and kill the connection midway, so they don't seem to do that and our file goes through. |
Does anyone mind if I port this to the web client? Not as robust as |
Will this work on the ios app? Or is this already solved? I need the cloudflare tunnel as I don't get into my homenetwork on other ways. |
I have the same question here... did you found anything related to that? |
Looks like this was "resolved" on release 1.52.0, however yesterday I was running into issues while uploading videos, using cloudflare instead of the direct IP or another proxy domain with the cloudflare "cloud" OFF. Anyone with the same issue? |
I installed immich yesterday and I also have the issue that large files > 100MB will fail on the Web Client when using cloudflare tunnel and on the App as well. |
I uploaded a video with 200mb this morning with my phone through the tunnel and it works. I am running version 1.103.1 atm |
immich server: v1.105.1 (installed through docker compose) Uploading through local UI works, but through the tunnel both app and webui fail. |
Folks, this PR is nearly a year old now, so let's not continue discussing in here. If you want actual chunked uploading, you can subscribe to #1674. If you need troubleshooting help, please open a new discussion. |
If your server is running behind a CloudFlare tunnel, the Flutter app fails to upload files larger than 100 MB. This can be solved if we add a
Transfer-Encoding: chunked
header to the request.